Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coupling to openfast 4.0 #1441

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Enable coupling to openfast 4.0 #1441

merged 4 commits into from
Jan 16, 2025

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jan 13, 2025 •
edited
Loading

Summary

Enable coupling to openfast 4.0.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Closes #1432

@marchdf marchdf requested a review from jrood-nrel January 13, 2025 21:38
@marchdf
Copy link
Contributor Author

marchdf commented Jan 13, 2025 •
edited
Loading

Things left for me to do:

@marchdf
Copy link
Contributor Author

marchdf commented Jan 15, 2025

To be crystal clear: this allows the user to choose the version of openfast they want to compile against. The default will be v3 of openfast. We are not deprecating v3 of openfast.

@marchdf marchdf marked this pull request as ready for review January 16, 2025 21:32
@marchdf marchdf merged commit 9fee431 into Exawind:main Jan 16, 2025
15 checks passed
@marchdf marchdf deleted the openfast-40 branch January 16, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrood-nrel jrood-nrel jrood-nrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: openfast 4.0 update?
2 participants
@marchdf @jrood-nrel